Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default site-wide og:image to config.toml param #188

Closed

Conversation

rajeshduggal
Copy link
Contributor

@rajeshduggal rajeshduggal commented May 6, 2018

Add a default site wide og:image tag that can be
overridden in each episode.

See: https://gohugo.io/functions/param

Closes #187

Signed-off-by: Rajesh Duggal [email protected]


This change is Reviewable

Add a default site wide og:image tag that can be
overridden in each episode.

See: https://gohugo.io/functions/param

Signed-off-by: Rajesh Duggal <[email protected]>
@rajeshduggal
Copy link
Contributor Author

@mattstratton can this same technique be used for the "locale" and perhaps some other vars? Thoughts?

@mattstratton
Copy link
Owner

I'm trying to make sure I understand what this is doing - this means you do NOT want to use the hard-coded name for default, but be able to specify one?

@rajeshduggal
Copy link
Contributor Author

@mattstratton can you confirm that currently with castanet when you visit the website's home page there is no og:image tag in the html. So when people share a link to the website home page (or any other non-episode page) on facebook, facebook doesn't see an og:image and so it tries to guess which image to show in the posting. Website owners should be able to specify a default website og:image tag, and that value should be overridden if an image is specified in each episode's web page. Do you agree? And does this code make that happen?

@rajeshduggal
Copy link
Contributor Author

@mattstratton let me know if you need additional clarity. Thanks!

@mattstratton
Copy link
Owner

Sorry for the delay on reviewing this - I'm going to try to puzzle through it in the next few days before merging.

@mattstratton
Copy link
Owner

I'm going to close this PR since things have drifted since it was submitted, and I will handle it in #187 which I need to get around to soon anyway :)

@rajeshduggal rajeshduggal deleted the default-og-image-tag branch April 17, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Missing og:image on non episode pages
2 participants