Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pihole V6 #190

Open
modem7 opened this issue Oct 31, 2023 · 7 comments
Open

Pihole V6 #190

modem7 opened this issue Oct 31, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request planned Will be implemented

Comments

@modem7
Copy link

modem7 commented Oct 31, 2023

What feature would you like added?

PiHole v6 has just been announced at the start of the month with quite a few changes, including the API and consolidated settings files as two notable (probably breaking) changes.

https://pi-hole.net/blog/2023/10/09/pi-hole-v6-beta-testing/

https://deploy-preview-338--pihole-docs.netlify.app/api/

May be worthwhile to have a look in case you haven't and use this issue as a staging ground to prepare or any questions that may be raised.

@mattwebbio mattwebbio added enhancement New feature or request planned Will be implemented labels Mar 22, 2024
@mattwebbio mattwebbio added this to the Pi-hole V6 support milestone Mar 22, 2024
@FurkanVG
Copy link

FurkanVG commented Aug 2, 2024

How is the progress looking for V6?

@timtjtim
Copy link
Contributor

timtjtim commented Aug 4, 2024

Gravity sync has been archived - given the different implementations ("acting on their admin interface" vs copying the databases / config files) this one does seem much easier to migrate.

In fact, given the move away from PHP to a new REST API, this project may become even simpler!

I'm planning to do some testing on this project soon :)

@timtjtim
Copy link
Contributor

timtjtim commented Aug 4, 2024

Putting my comments on this discussion to avoid spamming notifications

#391

@timtjtim
Copy link
Contributor

timtjtim commented Aug 6, 2024

@mattwebbio It would be good to add a development-v6 branch we can use as a target I think.

@mattwebbio
Copy link
Owner

@timtjtim Done! https://github.com/mattwebbio/orbital-sync/tree/development-v6

Also: thanks for taking the time to look at this. I'm in the process of moving, so my time is (temporarily) extremely limited. It's a huge help :)

@laitco
Copy link

laitco commented Aug 20, 2024

Gravity sync has been archived - given the different implementations ("acting on their admin interface" vs copying the databases / config files) this one does seem much easier to migrate.

In fact, given the move away from PHP to a new REST API, this project may become even easier!

I'm planning to do some testing on this project soon :)

Already done the migraton and it works. Just now waiting for v6-support and v6 release of Pihole :)

timtjtim added a commit to timtjtim/orbital-sync that referenced this issue Aug 21, 2024
timtjtim added a commit to timtjtim/orbital-sync that referenced this issue Aug 21, 2024
timtjtim added a commit to timtjtim/orbital-sync that referenced this issue Aug 21, 2024
timtjtim added a commit to timtjtim/orbital-sync that referenced this issue Aug 21, 2024
@timtjtim
Copy link
Contributor

timtjtim commented Aug 21, 2024

I'm going to split this into two PRs - the first will just change more into a factory pattern, but still only support v5. If we're happy with the approach, I'll add in the V6 stuff. In the meantime - in case I have to go AWOL for some reason - I've also added the basic v6 work I've done to another branch.

PR with factory pattern for comment: #406
Extra branch for safe-keeping: https://github.com/timtjtim/orbital-sync/blob/timtjtim/development-v6/v6-client-code/src/client/v6/index.ts

timtjtim added a commit to timtjtim/orbital-sync that referenced this issue Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planned Will be implemented
Projects
None yet
Development

No branches or pull requests

5 participants