Add a flake output for the helix cogs #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatrixManAtYrService
changed the base branch from
master
to
steel-event-system
MatrixManAtYrService
force-pushed
the
cogs-output
branch
from
9985bd0
to
6d3925e
Compare
These are necessary for creating dev environments which use the plugin system. Making them a flake output makes it easy to get them without having `cargo xtask code-gen` modify your ~/.config directory.
MatrixManAtYrService
force-pushed
the
cogs-output
branch
from
6d3925e
to
5b4a047
Compare
| std::fs::create_dir_all(&target_directory).unwrap_or_else(|err| { | ||
| panic!("Failed to create directory {:?}: {}", target_directory, err) | ||
| }); | ||
| eprintln!("Created directory: {:?}", target_directory); |
There was a problem hiding this comment.
I think that both if these are unlikely cases. Most users have a dir ~/.config, so they'll never see these. I was in a build sandbox where those files didn't exist and it wasn't obvious why the file generation was failing or where the generated files were ending up. These messages helped me, I figured I'd leave them here just in case others end up with the same confusion.
|
I'm using this now in my config with no issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can already ask the flake to build helix for you, this PR adds the ability to build the helix cogs also:
By default,
cargo xtask code-genmodifies~/.config. I find this easy to lose track of. For instance, I had plugins working on one machine and not on the other and I was scratching my head about what was different between those machines.This change makes it easy to just get the cogs without modifying my config, which is handy for creating dev environments which are isolated from the rest of my system (like this one, which is a work in progress).