Structured data updates #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattzeunert
commented
Feb 15, 2019
| obj = JSON.parse(JSON.stringify(obj)); | ||
|
|
||
| setValueAtJsonLdPath(obj, path, searchKey); | ||
| const jsonLines = JSON.stringify(obj, null, 2).split('\n'); |
There was a problem hiding this comment.
The line number we report doesn't apply to the JSON that's passed in, but rather to the stringified JSON. That's not an issue for the feature, but I'm it seems weird when using the sd-validation library as an API consumer.
Should we return the applicable JSON from the validate function?
There was a problem hiding this comment.
I agree it's weird from the library perspective, but I think we can punt and just file an issue/TODO/jsdoc comment to mark this explicitly.
| obj = JSON.parse(JSON.stringify(obj)); | ||
|
|
||
| setValueAtJsonLdPath(obj, path, searchKey); | ||
| const jsonLines = JSON.stringify(obj, null, 2).split('\n'); |
There was a problem hiding this comment.
I agree it's weird from the library perspective, but I think we can punt and just file an issue/TODO/jsdoc comment to mark this explicitly.
| @@ -21,6 +21,7 @@ describe('JSON-LD validation', () => { | |||
| assert.equal(errors.length, 1); | |||
| assert.equal(errors[0].message, 'Unknown keyword'); | |||
| assert.equal(errors[0].path, '@test'); | |||
| assert.equal(errors[0].line, 4); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.