Add user options to disable battery and certain connected messages #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt of supporting issue #17.
I wanted to make the changes not break existing configurations. and the options to be toggled per user, so I added to "Connection Management" section of commands the following commands:
The battery one toggles both "Phone battery restored" and "Your phone's battery is low" for the user.
The goal of toggle-verbose-notifications is to silence updates when everything is working as expected. If the status "Connected to Google Messages" is due to a disconnection longer for 5 minutes for example it will still show, but it will hide it when a session changes or when there is simply no activity.