Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy support #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add proxy support #166

wants to merge 1 commit into from

Conversation

tieong
Copy link

@tieong tieong commented Dec 13, 2023

@tulir
Copy link
Member

tulir commented Dec 13, 2023

This probably needs to be configurable. Bridges in particular currently expect that proxy settings only apply to the remote network, not Matrix.

@bellegarde-c
Copy link

If this PR fixes env support, this should not be an issue as you can configure NO_PROXY env variable for Matrix.

@tulir
Copy link
Member

tulir commented Mar 20, 2024

Env vars are added for the whole program, not individual ClientSessions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tieong @tulir @bellegarde-c