Allow config key override through env var #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pacien <[email protected]>
10 tasks
16 tasks
CRTified
added a commit
to CRTified/nixpkgs
that referenced
this pull request
Nov 10, 2020
The change that allows setting the secrets by an environment file had the undocumented side effect of allowing to set any key by the environment file (Related PR: mautrix/telegram#332). This is required to e.g. set `bridge.login_shared_secret`, which was not documented before.
10 tasks
ghost
mentioned this pull request
pacien
pushed a commit
to pacien/nixpkgs
that referenced
this pull request
Nov 16, 2022
The change that allows setting the secrets by an environment file had the undocumented side effect of allowing to set any key by the environment file (Related PR: mautrix/telegram#332). This is required to e.g. set `bridge.login_shared_secret`, which was not documented before. GitHub: closes NixOS#103347
winterqt
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Nov 21, 2022
The change that allows setting the secrets by an environment file had the undocumented side effect of allowing to set any key by the environment file (Related PR: mautrix/telegram#332). This is required to e.g. set `bridge.login_shared_secret`, which was not documented before. GitHub: closes #103347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility for the user to override configuration keys through the use of environment variables.
For instance, one could set a value for
telegram.bot_tokenby defining theMAUTRIX_TELEGRAM_TELEGRAM_BOT_TOKENenvironment variable.This is handy for some environment such as managed Docker containers or NixOS modules, as well as for quick testing.
The proposed changed haven't been tested.
Signed-off-by: pacien [email protected]