-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sending heic images #636
base: main
Are you sure you want to change the base?
Support sending heic images #636
Conversation
Implements feature request mautrix#635 by converting heic files to jpeg before attaching to a message
445e58f
to
80118c5
Compare
That library looks unmaintained and doesn't work on arm/arm64. The amount of C code in general should also be minimized, I don't think there are any Go heif decoders. |
There appears to be a fork of that library that does have arm support, but I'm not sure whether it's worth pursuing that given your other concerns. |
@raphaelcastaneda Maybe https://github.com/klippa-app/go-libheif could work |
This is a (really thin) wrapper around the much more active library: https://github.com/strukturag/libheif, so I'd opt to use that directly instead. I think it's a question for @tulir whether usage of that library here is acceptable. This library is also based on a C implementation, but at least the underlying library (https://github.com/strukturag/libde265) appears to have arm support. |
Why do we want the bridge to support a file type that whatsapp doesn't? |
That's the whole point. So the bridge can convert it to a supported format. |
Makes sense 👍 |
Implements feature request #635 by converting heic files to jpeg before attaching to a message