Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ Iqama time message screen #1118

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix/ Iqama time message screen #1118

merged 1 commit into from
Apr 25, 2024

Conversation

ghassenbenzahra123
Copy link
Contributor

📝 Summary

This PR fixes #1029

Description

Only show iqama time on subscreens when isIqamaMoreImportant is enabled.

Tests

🧪 Use case 1

💬 Description:

Launch the app and enable iqama is more imporant from the backoffice to see the iqamas on the subscreens.

Checklist:

  • Coding Standards: I have reviewed my code to ensure it follows the project's coding standards.
  • Testing: I have tested the changes and they work as expected.
  • Merge Conflicts: I have resolved any merge conflicts with the latest main/development branch.
  • Branch Status: The branch is up-to-date with the target branch (main/development).

@ghassenbenzahra123 ghassenbenzahra123 added the bug Something isn't working label Apr 23, 2024
@ghassenbenzahra123 ghassenbenzahra123 self-assigned this Apr 23, 2024
@ghassenbenzahra123 ghassenbenzahra123 linked an issue Apr 23, 2024 that may be closed by this pull request
Iqama time message screen #1029
Closed
YassinNouh21
YassinNouh21 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@YassinNouh21 YassinNouh21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrahim-zehhaf-mawaqit ibrahim-zehhaf-mawaqit merged commit 3c3c5c4 into main Apr 25, 2024
1 check passed
@ibrahim-zehhaf-mawaqit ibrahim-zehhaf-mawaqit deleted the fix/iqama-time-visible branch April 25, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YassinNouh21 YassinNouh21 YassinNouh21 approved these changes

Assignees

@ghassenbenzahra123 ghassenbenzahra123

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iqama time message screen
3 participants
@ghassenbenzahra123 @YassinNouh21 @ibrahim-zehhaf-mawaqit