feat/Switch to portrait reading mode #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `MoshafType` as a parameter in various functions to support multiple Quran versions. - Updated `DownloadQuranLocalDataSource` to handle versioning based on `MoshafType`. - Enhanced `DownloadQuranState` with states for checking downloads and handling errors. - Refactored Notifiers and Repositories to include `MoshafType` in state management. - Improved the UI with a new `DownloadQuranDialog` for better user interaction during downloads. - Cleaned up redundant code and improved error handling across the application.
- Updated `download_quran_popup.dart` to streamline dialog handling and improve state management. - Changed `getLocalQuranVersion` in `quran_download_repository.dart` to return an `Option<String>` for better null safety. - Enhanced `download_quran_notifier.dart` for more efficient state transitions and error handling. - Refactored local data operations in `download_quran_local_data_source.dart` to utilize `Option` for version management. - Improved moshaf switching logic in `moshaf_type_notifier.dart` and related UI components. - Removed unnecessary dialog calls in `quran_reading_screen.dart` to prevent duplicate dialogs.
- Introduced `isFirstTime` property in `MoshafState` to track first-time usage. - Updated `download_quran_notifier.dart` to prompt downloads for first-time users. - Enhanced `moshaf_type_notifier.dart` to initialize `isFirstTime` from shared preferences. - Added `setNotFirstTime` method to update the state after the first download. - Defined a constant for first-time usage in `constants.dart`.
YassinNouh21
changed the title
YassinNouh21
reviewed
Oct 8, 2024
lib/src/state_management/quran/reading/quran_reading_notifer.dart
Outdated
Show resolved
Hide resolved
# Conflicts: # lib/src/pages/quran/page/quran_reading_screen.dart # lib/src/state_management/quran/reading/quran_reading_notifer.dart
…ments - Updated focus node debug labels for consistency and clarity. - Removed unnecessary debug print statements for cleaner code.
- Removed redundant `super.dispose()` in `dispose()` method to avoid errors. - Added `heroTag: null` to FloatingActionButton instances to prevent hero animation conflicts. - Updated `_handlePageScrollDownFocusGroupNode` to check for portrait mode before handling arrow down key event.
…state update - Added custom color to the `CircularProgressIndicator` in QuranReadingScreen to match the theme. - Set `state = AsyncLoading()` in QuranReadingNotifier when starting SVG loading to ensure proper loading state management.
YassinNouh21
approved these changes
Oct 13, 2024
# Conflicts: # lib/src/pages/quran/page/quran_reading_screen.dart
ghassenbenzahra123
deleted the
feat/switch-portrait-mode-reading-quran
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR fixes #1226
📝 Screenshots
20241001_123745.mp4
Checklist: