feat: download all and single Surah #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/l10n/intl_en.arb # lib/src/data/data_source/quran/reciter_local_data_source.dart # lib/src/data/repository/quran/recite_impl.dart # lib/src/domain/error/recite_exception.dart # lib/src/pages/quran/page/reciter_selection_screen.dart # lib/src/pages/quran/page/surah_selection_screen.dart
- **Removed**: The `RiwayatModel` class, which has been deemed unnecessary in the current architecture. - **Updated**: Various files across the codebase to replace occurrences of `riwayahId` with `moshafId`, reflecting the new terminology. - **Changes in Data Handling**: Adjusted methods in `reciter_local_data_source.dart`, `quran_audio_player_notifier.dart`, and related classes to ensure all functionality correctly references `moshafId` instead of `riwayahId`. - **UI Updates**: Updated UI code in `reciter_selection_screen.dart`, `surah_selection_screen.dart`, and `surah_card.dart` to use `moshaf` instead of `riwayah`, ensuring consistency throughout the user interface. - **Improved Readability**: Enhanced code clarity by renaming variables and methods where needed, making future maintenance easier. This refactor aims to streamline the codebase and align with the new vocabulary for Quranic text recitation, improving overall code quality and maintainability.
…nd Refactor State Management - **Added**: `SurahDownloadInfo` class to encapsulate download progress for individual Surahs, improving clarity and maintainability. - **Refactored**: `DownloadAudioQuranState` to include `reciterId`, `moshafId`, and a list of `downloadingSuwar`, simplifying the state management for downloads. - **Updated**: Methods in `DownloadStateNotifier` to utilize the new `SurahDownloadInfo` structure for tracking download progress. - **Modified**: The `surah_selection_screen` to integrate the refactored state management, ensuring the UI reflects download progress accurately for each Surah. - **Improved**: Download logic in `quran_audio_player_notifier` and related files to utilize the new `DownloadStateProviderParameter`, enhancing the modularity of the download process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR addresses the enhancements and bug fixes for the Surah Player functionality.
Description
This update introduces several key features and improvements to the Surah Player, including:
Tests
🧪 Use case 1
💬 Description:
📷 Screenshots or GIFs (if applicable):
Checklist: