Removes the panic, throws a warning & returns an empty list, which should be expected behavior #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sntx626
suggested changes
Apr 6, 2023
src/main.rs
Outdated
| @@ -178,7 +178,7 @@ fn main() -> crossterm::Result<()> { | |||
|
|
|||
| if opt.list_languages { | |||
| opt.languages() | |||
| .expect("Couldn't get installed languages under config directory. Make sure the config directory exists.") | |||
| .expect("Couldn't get installed languages under the config directory. Make sure the config and language directory exist.") | |||
There was a problem hiding this comment.
This improves the error message.
However I agree with @omarkohl, the message should be printed as a warning and return an empty list with .or_else(vec![]).
There was a problem hiding this comment.
Since there's no logging this could look like the following:
if opt.list_languages {
opt.languages()
.or_else({
println!("Warning: Couldn't get installed languages under config directory. Make sure the config directory exists.");
vec![]
})
.iter()
.for_each(|name| println!("{}", name.to_str().expect("Ill-formatted language name.")));
return Ok(());
}
joao-vitor-sr
changed the title
joao-vitor-sr
commented
Apr 8, 2023
| @@ -177,8 +177,13 @@ fn main() -> crossterm::Result<()> { | |||
| } | |||
|
|
|||
| if opt.list_languages { | |||
| opt.languages() | |||
| .expect("Couldn't get installed languages under config directory. Make sure the config directory exists.") | |||
| match opt.languages() { | |||
There was a problem hiding this comment.
Since or_else methods on results don't return a default value, an if or a match is necessary
There was a problem hiding this comment.
(improving the explanation) the or_else will return another Result which has to be handled.
Sntx626
approved these changes
Apr 11, 2023
joao-vitor-sr
changed the title
max-niederman
force-pushed
the
fix_list_languages
branch
from
447e976
to
4e680a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #55