Remove duplicate value fields #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value was being copied from Fake for the sole purpose of rendering a template. The FakeName field does not make much sense as a field on a Method struct, it is not a property of a method. Instead of copying the value to a struct, change the templates to reference the root object using $, which is always the initial value of '.' when a template rendering is executed.
This value was being copied from Fake for the sole purpose of rendering a template. The FakePackage field does not make much sense as a field on a Method struct, it is not a property of a method. Instead of copying the value to a struct, change the templates to reference the root object using $, which is always the initial value of '.' when a template rendering is executed.
|
Thanks for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading over the code I noticed a couple fields on the
Methodstruct that I found particular hard to understand. After reading over the code I realized these fields held copies of values fromFake. They appear to exist solely to render values into the template, but do not feel like natural properties of aMethodtype.I noticed that at the bottom of https://golang.org/pkg/text/template/#hdr-Variables it says
$is always set to the initial value of.. Using$I was able to remove these copied values and use the original value from theFake.Fewer fields, especially fields that contain values which are copies of other values, should make the code easier to understand.