Shrink main package #110
Merged
Shrink main package #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stdout should only contain output that is requested by the user. Messages like "Writing" and "Done" are logs which should not be on stdout.
os.Exit should only be called from the main() function. If it is called from other functions then defers will not run before the program exits. Also use a string for cwd instead of a function. The value should not change, so there is no need to make the value lazy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full description in the commit message.
One of the stated goals in the readme of this project is to keep
mainsmall. I noticed some duplicate code and unused function in main that could be cleaned up.