Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import foreign interfaces #88

Closed
wants to merge 10 commits into from
Closed

Import foreign interfaces #88

wants to merge 10 commits into from

Conversation

elgohr
Copy link

@elgohr elgohr commented Jun 23, 2018

Fixes #87

@joefitzgerald
Copy link
Collaborator

@elgohr is this addressed in https://github.com/maxbrunsfeld/counterfeiter/releases/tag/v6.0.0?

@elgohr
Copy link
Author

elgohr commented Oct 14, 2018

@joefitzgerald I was going to cherry pick tests from elgohr@7e4c853 but locator is gone.
The new version seems to be pretty much a rewrite... Could you adapt the tests?

@joefitzgerald
Copy link
Collaborator

@elgohr I did just that and the test passes 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elgohr @joefitzgerald