Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme rollup-plugin-url mention #105

Closed
mcshaz opened this issue Apr 23, 2020 · 2 comments
Closed

Readme rollup-plugin-url mention #105

mcshaz opened this issue Apr 23, 2020 · 2 comments

Comments

@mcshaz
Copy link

mcshaz commented Apr 23, 2020

On windows filesystems, this plugin only finds the .map file pointed to with the //# sourceMappingURL= directive if the rollup-plugin-url plugin is added. This would also be great to have in the readme.

Thanks for your plugin!

mcshaz added a commit to mcshaz/rollup-plugin-sourcemaps that referenced this issue Apr 25, 2020
@maxdavidson
Copy link
Owner

Thank you for pointing out it doesn't work in Windows. I don't think recommending @rollup/plugin-url is the right approach, since that's more of hack and I'd rather fix the path resolution here instead. I created #116 to track this issue

@mcshaz
Copy link
Author

mcshaz commented May 3, 2020

That was actually the direction I was going in my fork of this repo, but wasn't actually sure if/when this issue would be seen. Thanks - I'll post further thoughts in #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants