Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for Rollup version 3 #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alan-agius4
Copy link

This fixes incorrect peer deps

  +-- [email protected]
  | +-- @rollup/[email protected]
  | | `-- [email protected] deduped invalid: "^1.20.0||^2.0.0" from node_modules/rollup-plugin-sourcemaps/node_modules/@rollup/pluginutils
  | `-- [email protected] deduped

This fixes incorrect peer deps

```
  +-- [email protected]
  | +-- @rollup/[email protected]
  | | `-- [email protected] deduped invalid: "^1.20.0||^2.0.0" from node_modules/rollup-plugin-sourcemaps/node_modules/@rollup/pluginutils
  | `-- [email protected] deduped
```
@justingrant
Copy link

We just ran across this in an update to our repo @js-temporal/polyfill. Thanks @alan-agius4 for saving us the hassle of filing the same PR!

If anyone else has the same issue, before this PR is merged here's how we worked around it in our package.json:

  "overrides": {
    "@rollup/pluginutils": "^5.0.2"
  },

@segevfiner
Copy link

segevfiner commented Dec 25, 2022

Fixes #127

@janbiasi
Copy link

janbiasi commented Mar 7, 2023

@maxdavidson what blocks this PR from being merged?

@NetWin
Copy link

NetWin commented Nov 30, 2023

@maxdavidson an ETA? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants