Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodejs20.x #744

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Add nodejs20.x #744

merged 1 commit into from
Nov 15, 2023

Conversation

o-alexandrov
Copy link
Contributor

AWS added support for Node.js 20 in the past few days.

Related comment from AWS.

@maxday
Copy link
Owner

maxday commented Nov 10, 2023

Hey @o-alexandrov!
thank you so much for your contribution!
Would you be able to create the associated folder under s3-uploader/runtimes ?
Also please note that it's not yet available as a supported runtime but you're right it seems that it's coming soon so as soon as it will be available I'll merge :)

@o-alexandrov
Copy link
Contributor Author

Thank you for pointing out the s3-uploader/runtimes and the great source to check actual cold starts across runtimes.
Updated PR w/ s3-uploader/runtimes

Copy link
Owner

@maxday maxday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's wait for official support before merging :)

@o-alexandrov
Copy link
Contributor Author

@maxday node.js 20 is available. It was available in SDK prior, so should be good (the ECR image is also marked as GA)

@WtfJoke
Copy link
Contributor

WtfJoke commented Nov 14, 2023

CDK has released Node.Js 20 support as well.
cdk release notes

Looking forwarded to seeing this merged :)

Signed-off-by: Olzhas Alexandrov <[email protected]>
@o-alexandrov
Copy link
Contributor Author

force-pushed to update a commit signature, due to my email update on GitHub

@WtfJoke
Copy link
Contributor

WtfJoke commented Nov 15, 2023

Thanks, let's wait for official support before merging :)

Its official now :) https://aws.amazon.com/blogs/compute/node-js-20-x-runtime-now-available-in-aws-lambda/

@RichiCoder1
Copy link
Contributor

Ha, I created #758 before seeing this PR exactly because it's official now. Would love to see this!

@maxday maxday merged commit 87b795d into maxday:main Nov 15, 2023
@maxday
Copy link
Owner

maxday commented Nov 15, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants