Stop TracedStatement throwing warnings for objects #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When objects are passed in as SQL parameters if they are able to be cast to string then we should do so. If we cannot cast them to string we will short circuit the mb_check_encoding test so that we never try to use any objects as a parameter of that function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour of
TracedStatement::checkParameters()will cause warnings to be raised when objects are passed in as a parameter. This should not always be the case.This PR adds support for both objects with and without
__toString()methods.If an object has a
__toString()method, then we will call that and use that as our parameter.If it does not, then we will short circuit the encoding check and just make it show up as
[BINARY DATA].Another option, which is preferred would be to add another possible value such as
[OBJECT classname]which would differentiate it from standard binary data.