Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content security policy errors by upgrading jquery (fixes #529) #561

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

Yannik
Copy link
Contributor

@Yannik Yannik commented Sep 19, 2023

This fixes the content security policy errors generated by jquery not propagating the nonce to nodes it creates. (As mentionen in #529).

I have tested this for regressions.

@Yannik
Copy link
Contributor Author

Yannik commented Sep 19, 2023

Actually, the minified jquery included in this repo has already been updated in 847216e.

Unfortunately, there was no tagged release since.

I'll keep this open since bower.json currently specifies the wrong jquery version.

@parallels999
Copy link
Contributor

parallels999 commented Sep 19, 2023

I'll keep this open since bower.json currently specifies the wrong jquery version.

^3.3, the symbol ^ means all the up versions on 3.x branch, so ^3.3 includes 3.7 and earlier

@Yannik
Copy link
Contributor Author

Yannik commented Sep 19, 2023

@parallels999 You're right! I'll let the maintainer decide if they want this change or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants