Reduce memory usage for consecutive requests with stacked data #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotdash
force-pushed
the
fix_quadratic_memory_usage
branch
from
d31fed7
to
0875abb
Compare
Currently, the session stores stacked data, which in turn might contain the session data if a RequestCollector is active. This leads to exponential growth in memory usage and rapid performance degradation if multiple requests add stacked data before the next time the debug bar is rendered. We can avoid this be temporarily removing the stacked data from the session while collection data.
dotdash
force-pushed
the
fix_quadratic_memory_usage
branch
from
0875abb
to
8fb920f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the session stores stacked data, which in turn might contain the session data if a RequestDataCollector is active. This leads to exponential growth in memory usage and rapid performance degradation if multiple requests add stacked data before the next time the debug bar is rendered.
We can avoid this be temporarily removing the stacked data from the session while collection data.
Fixes #665