Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyntaxInformation about options #218

Closed
maxitg opened this issue Mar 1, 2020 · 1 comment · Fixed by #454 or #592
Closed

SyntaxInformation about options #218

maxitg opened this issue Mar 1, 2020 · 1 comment · Fixed by #454 or #592
Assignees
@daneelsan
Labels
feature New functionality, or change in existing functionality wolfram language Requires Wolfram Language implementation

Comments

@maxitg
Copy link
Owner

maxitg commented Mar 1, 2020 •
edited
Loading

Currently, SyntaxInformation is not defined for options of most functions with the exception of RulePlot, i.e., the following

In[] := WolframModelPlot[{{1, 2, 3}}, "InvalidOption" -> 4]

should color "InvalidOption" in red, which does not currently do:
image

Expected behavior
It should do something similar to RulePlot:
image

Version:

  • OS: macOS 10.15.3 (19D76)
  • Wolfram Language Version: "12.1.0 for Mac OS X x86 (64-bit) (February 26, 2020)"
  • SetReplace git sha: 7fe0dc6
@maxitg maxitg added the weed Something isn't working label Mar 1, 2020
@maxitg maxitg self-assigned this Mar 1, 2020
@maxitg maxitg removed their assignment May 14, 2020
@daneelsan daneelsan mentioned this issue Oct 12, 2020
Merged
daneelsan added a commit that referenced this issue Oct 12, 2020
@daneelsan
Adding "OptionNames" in SyntaxInformation of WolframModelPlot. (#454)
2278ed1 
## Changes
* Closes #218.
* Adding "OptionNames" in `SyntaxInformation` of `WolframModelPlot`.

## Examples
```wl
In[] := WolframModelPlot[{{1, 2, 3}}, "InvalidOption" -> 4]
```
![image](https://user-images.githubusercontent.com/40190339/95776857-c0869e00-0c8a-11eb-93e7-74b8df0853b0.png)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/maxitg/setreplace/454)
<!-- Reviewable:end -->
@maxitg
Copy link
Owner Author

maxitg commented Oct 14, 2020

We need to do this for all other functions as well (e.g., SetReplace, HypergraphUnificationsPlot, etc.)

@maxitg maxitg reopened this Oct 14, 2020
@maxitg maxitg added feature New functionality, or change in existing functionality wolfram language Requires Wolfram Language implementation and removed weed Something isn't working labels Oct 14, 2020
@daneelsan daneelsan self-assigned this Nov 30, 2020
@daneelsan daneelsan mentioned this issue Jan 11, 2021
Merged
daneelsan added a commit that referenced this issue Jan 12, 2021
@daneelsan
Adding "OptionNames" in SyntaxInformation to all exposed symbols (#592)
7e0202e 
## Changes

* Closes #218.
* Adds "OptionNames" of `SyntaxInformation` for all exposed symbols with `Options`.

## Comments:

* List of symbols that were missing "OptionNames":
```wl
{HypergraphUnificationsPlot, SetReplace, SetReplaceAll, SetReplaceFixedPoint, SetReplaceFixedPointList, SetReplaceList, WolframModel}
```

## Examples

```wl
In[] := SetReplace[{{1, 2, 3}}, {{{1, 2, 3}} -> {4}}, 1,  "InvalidOption" -> "test"]
```
![image](https://user-images.githubusercontent.com/40190339/104142600-40a3c900-538a-11eb-9e73-9dc8d4d319d3.png)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/maxitg/setreplace/592)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daneelsan daneelsan

Labels
feature New functionality, or change in existing functionality wolfram language Requires Wolfram Language implementation
Projects
None yet
Milestone
No milestone
2 participants
@maxitg @daneelsan