Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performanceTest.wls for DevUtils #556

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Fix performanceTest.wls for DevUtils #556

merged 2 commits into from
Dec 8, 2020

Conversation

maxitg
Copy link
Owner

@maxitg maxitg commented Dec 8, 2020

Changes

  • ./performanceTest.wls got broken after the introduction of in-place builds DevUtils: inplace builds, caching of libraries, hot reloading #529. This PR fixes it.
  • As a result, ./performanceTest.wls no longer installs any paclets, and tests everything in-place.
  • Also added ./performanceTest.wls master @HEAD 2 to CI to prevent the script from breaking in the future, and to have an easy access to performance results.

Comments

  • Having it in CI causes a ~30 seconds slowdown.
  • I'm only running 2 tests instead of the default 5 to minimize that slowdown.
  • CI won't fail if there is a slowdown. The purpose of this PR is to test the script itself, not its output.

Examples


This change is Reviewable

@maxitg maxitg added weed Something isn't working infrastructure Has to do with changes to the development process, e.g., build scripts, CI, testing utilities wolfram language Requires Wolfram Language implementation labels Dec 8, 2020
@maxitg maxitg assigned aokellermann and taliesinb and unassigned aokellermann Dec 8, 2020
Copy link
Collaborator

@taliesinb taliesinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aokellermann and @maxitg)


performanceTest.wls, line 8 at r1 (raw file):

  Get["DevUtils/init.m"];
  Get["Kernel/init.m"];
,

Are you sure that you can get away with using relative paths like this? What if I invoke the script from a different directory to the one the script is in?

Copy link
Owner Author

@maxitg maxitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @aokellermann and @taliesinb)


performanceTest.wls, line 8 at r1 (raw file):

Previously, taliesinb (Taliesin Beynon) wrote…

Are you sure that you can get away with using relative paths like this? What if I invoke the script from a different directory to the one the script is in?

Good point. Fixed.

Copy link
Collaborator

@taliesinb taliesinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aokellermann)

@maxitg maxitg merged commit 63688e0 into master Dec 8, 2020
@maxitg maxitg deleted the fix/performanceTest branch December 8, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Has to do with changes to the development process, e.g., build scripts, CI, testing utilities weed Something isn't working wolfram language Requires Wolfram Language implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants