Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 549 prevent mailman-web dns lookup from throwing #681

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

mm534
Copy link
Contributor

@mm534 mm534 commented Jan 18, 2024

Addresses #549

There might be some neater options than just swallowing the exception, but I've tried to keep the change minimal.

Alternatives -

  • DJANGO_ALLOWED_HOSTS could override rather than extend, but that would be a breaking change.
  • We could introduce another env var to override the default behavior.

@maxking
Copy link
Owner

maxking commented Jan 22, 2024

This looks fine, fewer env vars to document are better. DJANGO_ALLOWED_HOSTS already exists, so no need add another one for just specifying the name of the container.

Thanks for your contribution!

@maxking maxking merged commit 1fc0716 into maxking:main Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants