Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting user_agent from $values should not depend on $sessionId #172

Closed
gkuhlmann opened this issue May 2, 2024 · 1 comment · Fixed by #173
Closed

Extracting user_agent from $values should not depend on $sessionId #172

gkuhlmann opened this issue May 2, 2024 · 1 comment · Fixed by #173

Comments

@gkuhlmann
Copy link

gkuhlmann commented May 2, 2024

We encountered this behavior after upgrading from MinFraud 1.x to 3.x

IMO the user_agent value should be extracted/removed from the $values array regardless of whether a session_id exists.

see

if ($sessionId) {
$userAgent = $this->remove($values, 'user_agent');
}

@oschwald
Copy link
Member

oschwald commented May 2, 2024

Thank you. That is certainly a bug. I am not sure what the intent was there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants