added callback function in uzfs_get_txg_diff_tree #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mayank <[email protected]>
Signed-off-by: mayank <[email protected]>
mynktl
force-pushed
the
modified_block_tree_changes
branch
from
a92afd6
to
ab043fe
Compare
vishnuitta
reviewed
Mar 13, 2018
lib/libzpool/uzfs_mtree.c
Outdated
| int | ||
| uzfs_get_txg_diff_tree(zvol_state_t *zv, uint64_t start_txg, uint64_t end_txg, | ||
| avl_tree_t **tree) | ||
| uzfs_zvol_traverse_t *func, void *arg) |
vishnuitta
reviewed
Mar 13, 2018
include/uzfs_mtree.h
Outdated
| @@ -22,10 +22,30 @@ | |||
| #ifndef _UZFS_MTREE_H | |||
| #define _UZFS_MTREE_H | |||
|
|
|||
| /* | |||
| * API to get modified blocks between start_txg and end_txg | |||
| * Note: API will alocate condensed tree and populate it witch | |||
jkryl
approved these changes
Mar 13, 2018
lib/libzpool/uzfs_mtree.c
Outdated
| int | ||
| uzfs_get_txg_diff_tree(zvol_state_t *zv, uint64_t start_txg, uint64_t end_txg, | ||
| avl_tree_t **tree) | ||
| uzfs_zvol_traverse_t *func, void *arg) |
There was a problem hiding this comment.
I think we should remove "tree" from function name for better clarity.
added 3 commits
March 13, 2018 16:17
Signed-off-by: mayank <[email protected]>
…nto modified_block_tree_changes
Signed-off-by: mayank <[email protected]>
jkryl
pushed a commit
that referenced
this pull request
Jun 26, 2018
…11) * [CCS 59] uZFS API to call dmu from istgt * [CCS-59] fix in travis and header for pkg-utils * Adding other header files for make pkg build * [CCS 59] added few header files to build pkg mod * [CCS 59]cstyle fixes, adding cstyle check to travis * Remove unnecessary header files,added TOTAL_TIME env * Incorporating review comments [CCS 59] * cstyle fix, removed getenv in uzfs_test * Merged libuzfs_ioctl into zfs_ioctl * cstyle fix, removed cstyle from travis * compilation issue with non-uzfs and userspace build Once zvol is created using 'zfs create -V' command, it can be opened by doing 'uzfs_open_dataset()', and use uzfs_write_data() and uzfs_read_data() APIs for doing IOs.
jkryl
pushed a commit
that referenced
this pull request
Jun 26, 2018
added callback function in uzfs_get_txg_diff Signed-off-by: mayank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in uzfs_get_txg_diff_tree API
This API will traverse zvol and execute callback function provided by caller with offset/len/blockid.