-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress noisy googleapiclient cache_discovery (file_cache) warning #27
Suppress noisy googleapiclient cache_discovery (file_cache) warning #27
Conversation
Hi @jasonqng, thanks for contribution! WDYT if we'll set logging level to the level which is used in df2gspread lib, so users could change logging level when he wants, I don't really want to see this hardcoded. |
Sure @maybelinot, that's fine with not hard coding it so long as I don't have to override it every time. Can you suggest or move to wherever it should go? My messy notebooks thank you! |
I am using the master branch of df2gspread. Is this issue still under development? While the output is valid, the errors preceding the output are distracting. I have used both of the following in the code with no effect.
The only effective method I have found to suppress these errors is to redirect STDERR to nul or a log file. The errors I get are: C:\Users\Glenn\Desktop\gsp2df\rawOut>python gspread2df_test.py
|
@jasonqng @gwiensx What was the intent to change logging level? If there wasn't could you just keep Sorry for delayed review.. |
@jasonqng @gwiensx Reverted the logging setting (so it's back to the default; I don't touch it) and confirmed the warning is still suppressed for me. Can't guarantee it suppresses it for all, but maybe this is a safe incremental step? Thanks for the suggestion! |
@maybelinot, @jasonqng My purpose for including the logging business was an attempt to suppress verbosity in discussion of similar errors here. (googleapis/google-api-python-client#299). I will download and test again using the new code. Thank you |
@maybelinot, @jasonqng On retesting using new gfiles.py, no errors or warnings of any kind! I'm still learning how this site works, so many thanks for your patience with my floundering questions, and for making this change. |
@gwiensx No problem, thanks for validation 😄 |
Currently, if you upload or download with oauth2client>4.0.0, you get the below warning.
This PR suppresses this warning using the suggestion in this google-api-client thread: googleapis/google-api-python-client#299.
Tested again with change in this PR, and warning is successfully suppressed and upload still succeeds.
No tests added since this does not affect functionality, merely removes the verbose warning which has minimal (right?) effect on performance.
@maybelinot