Decrease compile time with nanostack-libservice #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanostack-libservice involves two parts: common (e.g. libip4string) and
nanostack-specific (e.g. nvmHelper). For nanostack-specific, it needs to
link nanostack hal and will pull in 200+ nanostack files for compile.
This is unnecessary for common only application e.g. lwipstack. To fix this,
the following strategy is applied for nanostack-libservice cmake listfile:
1. For compiling nanostack-specific, it doesn't rely on nanostack hal
because its needed header file has placed underneath
(mbed-client-libservice/platform).
2. For application needing the nanostack-specific, the nanostack cmake
listfile shall specify the link dependency.
ccli8
force-pushed
the
nanostack-libservice_decrease_compile_time
branch
from
354dd7f
to
63c0db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
nanostack-libservice involves two parts: common (e.g. libip4string) and nanostack-specific (e.g. nvmHelper). For nanostack-specific, it needs to link nanostack hal and will pull in 200+ nanostack files for compile. This is unnecessary for common only application e.g. lwipstack. To fix this, the following strategy is applied for nanostack-libservice cmake listfile:
This actually rolls back #378 on this line
Pull request type