reload existing tag names only first time and after a tag name collit…

…ion to avoid unnecessary database queries
mbleigh · Jun 19, 2017 · d43736f · d43736f
1 parent 4d9a10c
commit d43736f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/acts_as_taggable_on/tag.rb b/lib/acts_as_taggable_on/tag.rb
@@ -69,17 +69,17 @@ def self.find_or_create_all_with_like_by_name(*list)
 
       return [] if list.empty?
 
+      existing_tags = named_any(list)
       list.map do |tag_name|
         begin
           tries ||= 3
-
-          existing_tags = named_any(list)
           comparable_tag_name = comparable_name(tag_name)
           existing_tag = existing_tags.find { |tag| comparable_name(tag.name) == comparable_tag_name }
           existing_tag || create(name: tag_name)
         rescue ActiveRecord::RecordNotUnique
           if (tries -= 1).positive?
             ActiveRecord::Base.connection.execute 'ROLLBACK'
+            existing_tags = named_any(list)
             retry
           end