Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@acts_as_taggable_on_cache_columns should be reset by reset_column_information #621

Closed
warp opened this issue Jan 6, 2015 · 2 comments
Closed

@acts_as_taggable_on_cache_columns should be reset by reset_column_information #621

warp opened this issue Jan 6, 2015 · 2 comments

Comments

@warp
Copy link
Contributor

warp commented Jan 6, 2015

If its not reset then columns will continue to return the cached value and not requery the database as expected.
@warp warp closed this as completed Jan 6, 2015
@warp warp reopened this Jan 6, 2015
@seuros
Copy link
Collaborator

seuros commented Jan 6, 2015

I don't think so, that will be a breaking change and a regression.

On Tue, Jan 6, 2015 at 8:27 PM, Ben Tillman [email protected]
wrote:

I see the cache has been removed in master

—
Reply to this email directly or view it on GitHub
#621 (comment)
.

@warp
Copy link
Contributor Author

warp commented Jan 6, 2015

Yeah my mistake it was github search playing tricks on me :)

@seuros seuros closed this as completed in 5697535 Jan 6, 2015
seuros added a commit that referenced this issue Jan 6, 2015
@seuros
Merge pull request #622 from fatfreecrm/fix/clear_column_cache_on_res…
da179e8 
…et_column_information

clears column cache on reset_column_information resolves #621
markedmondson pushed a commit to markedmondson/acts-as-taggable-on that referenced this issue Jun 18, 2015
Merge branch 'master' into integration
129c8fd 
* master: (26 commits)
  mbleigh#623 collation parameter is ignored if it generates an exception.
  Update release date for 3.5.0
  Update README.md
  Changing ActsAsTaggable to ActsAsTaggableOn
  version 3.5.0
  Add context constraint to find_related_* methods. Fixes mbleigh#628
  added rake rule and a config parameter to force binary collation (MySql)
  added migration and rake task
  mbleigh#623: added manual column alter suggestion to fix special characters in tags (MySql only)
  version bump
  Add context constraint to find_related_* methods. Fixes mbleigh#628
  Fixing typo in docs with strong typing
  Namespaced TagList usage in a customer parser
  version bump, test on ruby 2.2, remove rails edge from matrix.
  clears column cache on reset_column_information resolves mbleigh#621
  Use the new build env on Travis
  Update README.md
  sha_prefix should not be random
  Fix milestones link
  Meet interface expectation for active record.
  ...
tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this issue Mar 19, 2021
@warp
clears column cache on reset_column_information resolves mbleigh#621
c4c8fb7
tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this issue Mar 19, 2021
@seuros
Merge pull request mbleigh#622 from fatfreecrm/fix/clear_column_cache…
969bd42 
…_on_reset_column_information

clears column cache on reset_column_information resolves mbleigh#621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@warp @seuros