-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*** NoMethodError Exception: undefined method `set_attribute_was' for #955
Comments
tried to understand how to recreate the old behavior with the new mutation tracker .... so far no luck :( when the line in question is removed you won't see the actual change when using |
From what I could gather they have changed the implementation of |
|
Are there plans to fix this? |
This is partially also preparation for Rails 6. However the upgrade can only be made once acts_as_taggable_on fixes #955 mbleigh/acts-as-taggable-on#955 Signed-off-by: Tristan <[email protected]>
To fix mbleigh#955 When the Rails version is 6.0.0, it becomes true, so I want to skip set_attribute_was.
Any updates on this? Thanks ❤️ |
I tested and found #968 solved this issue! |
rails: 6.0.0.rc1
set_attribute_was method has been removed from ActiveModel. Now previous changes are being tracked by ActiveModel::AttributeMutationTracker, I think.
Anyways, I just commented the set_attribute_was in a forked branch to make it work. This might have some consequences not sure how severe.
Do you want me to raise that request? or do you have any other suggestion as to How to handle this?
Please let me know, I'll be glad to help out.
The text was updated successfully, but these errors were encountered: