Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this pull request cause we noticed that this gem was making duplicate queries for the same resources on our app, and decided to dig in to find the root cause.
The main usecases were :
save!
with nothing changed, the gem queries existing Tags and Tags in current context, even tho nothing changed so the gem should not have to query anythingsave!
with changes (or not), the gem seems to query the same contexts multiple times, which is redundantHere are improvements for the first and last usecase. The middle one seem more complex, and is left for a future improvement.
Improvements
For the delete improvement :
We simply only reload the
tag
record if already loaded. Otherwisetag.reload
would load it twice.For the
save!
improvement :Since we initialize
custom_contexts
withtaggings.map(&:context).uniq
, buttagging_contexts
uses bothself.class.tag_types.map(&:to_s)
andcustom_contexts
, we have duplicates contexts intagging_contexts
which results in the gem attempting to save each context twice.Add a
uniq
totagging_contexts
to ensure that does not happen.