Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope tags for taggable type #923

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Scope tags for taggable type #923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5eb1de
added scope - untested
florianeck Sep 28, 2018
014155e
force .to_s to avoid weird nil exceptions
florianeck Sep 29, 2018
c3e0528
added 'gem sqlite3' to gemfile to run specs
florianeck Sep 29, 2018
05cd04a
added specs
florianeck Sep 29, 2018
992ebf9
update version
florianeck Sep 29, 2018
7411685
Update Gemfile
seuros Oct 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/acts_as_taggable_on/tag.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def validates_name_uniqueness?
### SCOPES:
scope :most_used, ->(limit = 20) { order('taggings_count desc').limit(limit) }
scope :least_used, ->(limit = 20) { order('taggings_count asc').limit(limit) }
scope :for_taggable_type, -> (type = nil) { joins(:taggings).where('taggings.taggable_type' => Array.wrap(type)) }

def self.named(name)
if ActsAsTaggableOn.strict_case_match
Expand Down
2 changes: 1 addition & 1 deletion lib/acts_as_taggable_on/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module ActsAsTaggableOn
VERSION = '6.0.1'
VERSION = '6.0.2'
end
24 changes: 23 additions & 1 deletion spec/acts_as_taggable_on/tag_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,29 @@
@tag = ActsAsTaggableOn::Tag.new
@user = TaggableModel.create(name: 'Pablo')
end



# scopes
describe 'for_taggable_type' do
before(:each) do
@tag_1 = ActsAsTaggableOn::Tag.create(name: 'Awesome')
@tag_2 = ActsAsTaggableOn::Tag.create(name: 'notSoCool')
@tagging_1 = ActsAsTaggableOn::Tagging.create(taggable: @user, tag: @tag_1, context: 'tags')
@tagging_2 = ActsAsTaggableOn::Tagging.create(taggable_type: 'AnyClass', taggable_id: 1, tag: @tag_2, context: 'tags')
# this one is not to be found...
@tagging_3 = ActsAsTaggableOn::Tagging.create(taggable_type: 'DontCare', taggable_id: 1, tag: @tag_2, context: 'tags')
end

specify "finds one given taggable type" do
expect(ActsAsTaggableOn::Tag.for_taggable_type(TaggableModel.to_s)).to match_array([@tag_1])
end

specify "finds multiple give taggable type" do
expect(ActsAsTaggableOn::Tag.for_taggable_type([TaggableModel.to_s, @tagging_2.taggable_type])).to match_array([@tag_1, @tag_2])
end


end

describe 'named like any' do
context 'case insensitive collation and unique index on tag name', if: using_case_insensitive_collation? do
Expand Down