Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

503 error on subnet aggregation with missing prefix length #55

Closed
candlerb opened this issue Jun 12, 2020 · 5 comments
Closed

503 error on subnet aggregation with missing prefix length #55

candlerb opened this issue Jun 12, 2020 · 5 comments

Comments

@candlerb
Copy link

candlerb commented Jun 12, 2020

(Expansion of issue from #31) This is a minor usability / data validation issue. To reproduce:

  • Go to Graphs tab, select last 24 hours
  • Go to Flows tab
  • Under IP Aggregation > Source select "IPv4 subnets", but leave the prefix length empty
  • Click Process Data

Result is a red 503 error:

image

Got 503 - Service unavailable. NfDump: Initialization failed. /usr/local/bin/nfdump -M '/var/nfsen/profiles-data/live/gw' -R '2020/06/11/nfcapd.202006110810:2020/06/12/nfcapd.202006120805' -c '20' -o 'csv' -a '-Asrcip4' 2>&1

The problem is fixed if you type (say) "24" in the prefix length box.

I think the issues are:

  • if nfsen-ng shows grey "/24" in the box, the user assumes that /24 is already taken as default
  • if you type "/24" it fails since this is only a 2-digit box; then you realise you have to enter "24"

I think it would be better if the slash were moved out of the selection boxes:

      [ IPv4 Subnets     ] / [   ]

The box can display a grey "24" (making it clearer what the user is expected to enter here). Then if the user leaves this blank, 24 can be supplied to the backend.

@mbolli
Copy link
Owner

mbolli commented Oct 1, 2020

Fixed in 5f2702e. When I find a way to add the slash as a "watermark" in the input field, I will do so.

@mbolli mbolli closed this as completed Oct 1, 2020
@candlerb
Copy link
Author

candlerb commented Oct 1, 2020

How about you just put a literal slash character in front of the input box?

@mbolli
Copy link
Owner

mbolli commented Oct 1, 2020

This messes with the grid system and puts the subnet input box on the next line.

@candlerb
Copy link
Author

candlerb commented Oct 1, 2020

WFM if I reduce width: 30% to width: 25% on the prefix box, and insert

<div class="pull-left" style="width: 5%; font-size: 170%; text-align: center;">/</div>

before it.

image

@mbolli
Copy link
Owner

mbolli commented Oct 1, 2020

managed to do it in the input field :) thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants