Added missing nfdump column names #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing nfdump column names to the nfdump_translation var and render_table function to fix a bug where some Statistics reports output was broken (missing half of the data when using order-by other then "Flows").
|
great addition, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing nfdump column names to the nfdump_translation var and render_table function to fix a bug where some Statistics reports output was broken (missing half of the data when using order-by other then "Flows").
Bug: When running any of the "IP address" Statistics reports AND using any "Order by" method other than "Flows", half of the report output is missing. All data after the "Flows (%)" column is missing. When using"Order by = Flows" the report output is good and all columns are displayed correctly.
Cause: It appears that the nfdump csv output has different column names when using "-s ip/flows" report compared to when running a "-s ip/bytes" or other order-by method. Some of these column names are not defined in nfsen-ng/frontend/js/nfsen-ng.js in the "nfdump_translation" var.
NFDUMP columns returned when using -s 'ip/flows'
ts,te,td,pr,val,fl,flP,ipkt,ipktP,ibyt,ibytP,ipps,ibps,ibpp
NFDUMP columns returned when using -s 'ip/bytes'
ts,te,td,pr,val,fl,flP,pkt,pktP,byt,bytP,pps,bps,bpp
Fix: Add the missing fields "pktP" and "bytP" to the "nfdump_translation" var in nfsen-ng.js.