Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose featureCount property. Fixes #40. #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Expose featureCount property. Fixes #40. #41

wants to merge 2 commits into from

Conversation

stevage
Copy link

@stevage stevage commented Jan 5, 2018

No description provided.

@mbostock
Copy link
Owner

mbostock commented Jan 9, 2018

Could we call it “size” instead of “featureCount”?

@stevage
Copy link
Author

stevage commented Jan 9, 2018

Might be confused with file size, but up to you.

petitlegume
petitlegume suggested changes Jan 13, 2021
View reviewed changes
Copy link

@petitlegume petitlegume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shoud use getUint32 instead of getUint16. The number of records in the file refers to the byte offset 4 - 7 in the DBF head.

petitlegume pushed a commit to petitlegume/shapefile that referenced this pull request Jan 13, 2021
size now display the correct size. It now takes the record length fro…
6f90f4e 
…m bytes 4-7. this fixes mbostock#41.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petitlegume petitlegume petitlegume requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevage @mbostock @petitlegume