feat: Env vars to skip SMS and email sending #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could already configure which modules to use by environment (so test can use a different module than prod). This adds the ability to override via an environment variable. This allows us to turn off email and SMS sending from a single (dev-blue) server.
ErinLMoore
reviewed
Sep 7, 2023
| Helper functions for defining runtime configuration. | ||
| """ | ||
|
|
||
| @spec module_from_string_or_default(String.t() | nil, module()) :: module() |
There was a problem hiding this comment.
Looks like this isn't being called anymore
There was a problem hiding this comment.
Good catch! I forgot to remove those but did now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1/2 of Turn off email and SMS sending on dev-blue
We could already configure which modules to use by environment (so test can use a different module than prod). This adds the ability to override via an environment variable. This allows us to turn off email and SMS sending from a single (dev-blue) server.