Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case where minute is nil in trip controller times #1454

Closed
wants to merge 1 commit into from
Closed

Handle case where minute is nil in trip controller times #1454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/concierge_site/lib/param_parsers/param_time.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,18 @@ defmodule ConciergeSite.ParamParsers.ParamTime do
~T[12:00:00]
iex> ConciergeSite.ParamParsers.ParamTime.to_time(nil)
nil
iex> ConciergeSite.ParamParsers.ParamTime.to_time(%{"am_pm" => "PM", "hour" => "12", "minute" => nil})
~T[12:00:00]
"""
@spec to_time(map) :: Time.t()
def to_time(nil), do: nil

def to_time(form_time) do
hour = hour(form_time["hour"], form_time["am_pm"])
minute = String.to_integer(form_time["minute"])

minute =
if is_binary(form_time["minute"]), do: String.to_integer(form_time["minute"]), else: 0

second = 0

{:ok, time} = Time.from_erl({hour, minute, second})
Expand Down
Loading