-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented PullRequest decoration to AzureDevOps server (issue/102 8 1support) #123
Commits on Feb 2, 2020
-
Add support for Sonarqube 8.1.0
Sonarqube 8.1 removed the concept of short and long lived branches, instead simplifying the setup to either `BRANCH` or `PULL_REQUEST`. This release of Sonarqube also moved the management of Pull Request decoration into a standard User Interface calling a set of 'ALM' services that provide the management of decorators, and the binding of each project to these decorators. However the implementation of these services is not included in the Community Edition of Sonarqube, although the UI is made visible based on the presence of the branch management components provided by this plugin. This change therefore introduces the services required to support UI components for the management of Pull Request decoration, as well as updating the handling of the configuration and loading of branches to support the removal of the SHORT/LONG branch constructs. As these changes require the reference of classes that were not present in older version of Sonarqube (namely `AlmSettingsDao` and `ProjectAlmSettingsDao`), the compatibility interfaces for these versions have been removed, as well as any methods and classes that existed purely to allow these versions to be supported by this plugin. Given the standard UI provides a restricted set of fields for creating and binding each Pull Request decorator, some of the patterns that were previously used by this plugin for configuring the decoration of Pull Requests do not fit into this UI, and were awkward to find/manage when moved to another screen in the UI. This results in the configuration for disabling the addition and removing of comments on Merge Requests being removed from the plugin, with the Gitlab decorator removing the deleting of old comments since this was leading to discussion boxes being shown in Gitlab with no content, and the BitBucket decorator removing since it can't work out which user posted comments based purely on the configuration provided by Sonarqube. To ensure the UI works for all configuration options, the services for configuring and binding Azure DevOps configuration have been included in this change-set, although no decorator currently exists for this ALM, so any project attempting to use this configuration will get a warning appear in the CE logs when attempting to use this decorator. Similarly, as the UI does not provide any options for configuring the URL for the Gitlab API, or the Slug/name of the project on the binding, a `Sensor` has been added into the scanner to detect these properties from injection by the Gitlab CI Runner, as well as injection directly from scanner arguments of `com.github.mc1arke.sonarqube.plugin.branch.pullrequest.gitlab.url` and `com.github.mc1arke.sonarqube.plugin.branch.pullrequest.gitlab.repositorySlug` for the repository URL and repository-name configuration entries.
Configuration menu - View commit details
-
Copy full SHA for fdb382a - Browse repository at this point
Copy the full SHA fdb382aView commit details
Commits on Feb 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a228fc0 - Browse repository at this point
Copy the full SHA a228fc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dfad7d - Browse repository at this point
Copy the full SHA 3dfad7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5776c97 - Browse repository at this point
Copy the full SHA 5776c97View commit details -
Configuration menu - View commit details
-
Copy full SHA for edb6e12 - Browse repository at this point
Copy the full SHA edb6e12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4090510 - Browse repository at this point
Copy the full SHA 4090510View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d85835 - Browse repository at this point
Copy the full SHA 2d85835View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e9c59c - Browse repository at this point
Copy the full SHA 9e9c59cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cae9131 - Browse repository at this point
Copy the full SHA cae9131View commit details
Commits on Feb 20, 2020
-
mc1arke#90: Use correct field to retrieve Github repository name
The Github ALM Binding Web Service uses the `AlmRepo` field to store the repository name, but the Github decorator was using `AlmSlug` to try and retrieve the repository name, so was getting a `null` value back and failing to find a matching repository. Switching to using `AlmRepo` in the decorator overcomes this issues.
Configuration menu - View commit details
-
Copy full SHA for 87fc1b5 - Browse repository at this point
Copy the full SHA 87fc1b5View commit details
Commits on Mar 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5d4b432 - Browse repository at this point
Copy the full SHA 5d4b432View commit details
Commits on Mar 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a93110a - Browse repository at this point
Copy the full SHA a93110aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f327b0 - Browse repository at this point
Copy the full SHA 5f327b0View commit details
Commits on Mar 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e04f486 - Browse repository at this point
Copy the full SHA e04f486View commit details
Commits on Mar 8, 2020
-
mc1arke#102 add Azure object class and small refactoring
Configuration menu - View commit details
-
Copy full SHA for 3e7d57c - Browse repository at this point
Copy the full SHA 3e7d57cView commit details
Commits on Mar 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b42d8e6 - Browse repository at this point
Copy the full SHA b42d8e6View commit details -
mc1arke#102 add: closed issue in sonar, resolve in Azure
Configuration menu - View commit details
-
Copy full SHA for 174483a - Browse repository at this point
Copy the full SHA 174483aView commit details
Commits on Mar 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 05a5224 - Browse repository at this point
Copy the full SHA 05a5224View commit details -
Configuration menu - View commit details
-
Copy full SHA for 885e1b3 - Browse repository at this point
Copy the full SHA 885e1b3View commit details
Commits on Mar 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e197ff8 - Browse repository at this point
Copy the full SHA e197ff8View commit details -
Configuration menu - View commit details
-
Copy full SHA for db4f93e - Browse repository at this point
Copy the full SHA db4f93eView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc9a1cc - Browse repository at this point
Copy the full SHA dc9a1ccView commit details
Commits on Mar 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8670a7f - Browse repository at this point
Copy the full SHA 8670a7fView commit details
Commits on Mar 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7c6d8a1 - Browse repository at this point
Copy the full SHA 7c6d8a1View commit details -
Merge branch 'issue/102-8_1support' of https://github.com/Iloer/sonar…
…qube-community-branch-plugin into issue/102-8_1support
Configuration menu - View commit details
-
Copy full SHA for 6903c45 - Browse repository at this point
Copy the full SHA 6903c45View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd58369 - Browse repository at this point
Copy the full SHA fd58369View commit details -
Merge branch 'issue/102-8_1support' of https://github.com/Iloer/sonar…
…qube-community-branch-plugin into issue/102-8_1support
Configuration menu - View commit details
-
Copy full SHA for 0289c4f - Browse repository at this point
Copy the full SHA 0289c4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7401aa3 - Browse repository at this point
Copy the full SHA 7401aa3View commit details
Commits on Mar 30, 2020
-
mc1arke#102 attempt to close comment in AzureDevOps by issue.key
Configuration menu - View commit details
-
Copy full SHA for 935afff - Browse repository at this point
Copy the full SHA 935afffView commit details