Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented PullRequest decoration to AzureDevOps server (issue/102 8 1support) #123

Closed
wants to merge 29 commits into from

Commits on Feb 2, 2020

  1. Add support for Sonarqube 8.1.0

    Sonarqube 8.1 removed the concept of short and long lived branches, instead simplifying the setup to either `BRANCH` or `PULL_REQUEST`. This release of Sonarqube also moved the management of Pull Request decoration into a standard User Interface calling a set of 'ALM' services that provide the management of decorators, and the binding of each project to these decorators. However the implementation of these services is not included in the Community Edition of Sonarqube, although the UI is made visible based on the presence of the branch management components provided by this plugin.
    
    This change therefore introduces the services required to support UI components for the management of Pull Request decoration, as well as updating the handling of the configuration and loading of branches to support the removal of the SHORT/LONG branch constructs. As these changes require the reference of classes that were not present in older version of Sonarqube (namely `AlmSettingsDao` and `ProjectAlmSettingsDao`), the compatibility interfaces for these versions have been removed, as well as any methods and classes that existed purely to allow these versions to be supported by this plugin.
    
    Given the standard UI provides a restricted set of fields for creating and binding each Pull Request decorator, some of the patterns that were previously used by this plugin for configuring the decoration of Pull Requests do not fit into this UI, and were awkward to find/manage when moved to another screen in the UI. This results in the configuration for disabling the addition and removing of comments on Merge Requests being removed from the plugin, with the Gitlab decorator removing the deleting of old comments since this was leading to discussion boxes being shown in Gitlab with no content, and the BitBucket decorator removing since it can't work out which user posted comments based purely on the configuration provided by Sonarqube.
    
    To ensure the UI works for all configuration options, the services for configuring and binding Azure DevOps configuration have been included in this change-set, although no decorator currently exists for this ALM, so any project attempting to use this configuration will get a warning appear in the CE logs when attempting to use this decorator. Similarly, as the UI does not provide any options for configuring the URL for the Gitlab API, or the Slug/name of the project on the binding, a `Sensor` has been added into the scanner to detect these properties from injection by the Gitlab CI Runner, as well as injection directly from scanner arguments of `com.github.mc1arke.sonarqube.plugin.branch.pullrequest.gitlab.url` and `com.github.mc1arke.sonarqube.plugin.branch.pullrequest.gitlab.repositorySlug` for the repository URL and repository-name configuration entries.
    mc1arke committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    fdb382a View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2020

  1. [GITLAB] URL needs to point to the GitLab API

    tisoft authored and mc1arke committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    a228fc0 View commit details
    Browse the repository at this point in the history
  2. [Gitlab] reenable deletion of comments

    tisoft authored and mc1arke committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    3dfad7d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5776c97 View commit details
    Browse the repository at this point in the history
  4. [GITLAB] auto config branch/MR

    tisoft authored and mc1arke committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    edb6e12 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4090510 View commit details
    Browse the repository at this point in the history
  6. Fix adding discussions for gitlab

    uwej711 authored and mc1arke committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    2d85835 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9e9c59c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cae9131 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. mc1arke#90: Use correct field to retrieve Github repository name

    The Github ALM Binding Web Service uses the `AlmRepo` field to store the repository name, but the Github decorator was using `AlmSlug` to try and retrieve the repository name, so was getting a `null` value back and failing to find a matching repository. Switching to using `AlmRepo` in the decorator overcomes this issues.
    ndeitch authored Feb 20, 2020
    Configuration menu
    Copy the full SHA
    87fc1b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2020

  1. [email protected]

    Initial commit with test
    Иван Варнавский committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    5d4b432 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. [email protected]

    add getContextProperty method
    Иван Варнавский committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    a93110a View commit details
    Browse the repository at this point in the history
  2. [email protected]

    fix test
    Иван Варнавский committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    5f327b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. [email protected]

    Add POST PR Status
    Iloer committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    e04f486 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2020

  1. [email protected]

    mc1arke#102 add Azure object class and small refactoring
    Iloer committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    3e7d57c View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. [email protected]

    mc1arke#102 add azure thread with issue
    Iloer committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    b42d8e6 View commit details
    Browse the repository at this point in the history
  2. [email protected]

    mc1arke#102 add: closed issue in sonar, resolve in Azure
    Iloer committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    174483a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. [email protected]

    mc1arke#102 add unit tests
    Iloer committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    05a5224 View commit details
    Browse the repository at this point in the history
  2. [email protected]

    mc1arke#102 small refactoring
    Iloer committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    885e1b3 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. [email protected]

    mc1arke#102 Fix unit test
    Iloer committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    e197ff8 View commit details
    Browse the repository at this point in the history
  2. [email protected]

    remove unused code
    Iloer committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    db4f93e View commit details
    Browse the repository at this point in the history
  3. [email protected]

    remove star import
    Iloer committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    dc9a1cc View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2020

  1. [email protected]

    mc1arke#102 comment fixes
    Iloer committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    8670a7f View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. [email protected]

    Иван Варнавский authored and Iloer committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    7c6d8a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6903c45 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fd58369 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0289c4f View commit details
    Browse the repository at this point in the history
  5. [email protected]

    mc1arke#102 enum to UPPERCASE
    Iloer committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    7401aa3 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. [email protected]

    mc1arke#102 attempt to close comment in AzureDevOps by issue.key
    Iloer committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    935afff View commit details
    Browse the repository at this point in the history