Add support for Sonarqube 8.2.0 #156

mc1arke · 2020-04-19T22:14:14Z

Sonarqube 8.2 introduced a new ProjectDto with associated changes in ProjectAlmSettingsDao to require this new class in various methods, as well as changes in ComponentFinder to allow retrieval of instances of a project.

As this class and the associated methods did not exist in previous versions of Sonarqube, this change breaks backwards compatibility, so means the plugin will now only support Sonarqube 8.2.

Sonarqube 8.2 also provides the ability to set the optional URL parameter on a Gitlab project so that scans run outside of Gitlab CI operate properly, so the additional parameter is now included in the appopriate WebServices and the Gitlab decorator.

mc1arke · 2020-04-19T22:19:40Z

As per #58, the initial scan of a branch does not return the expected set of initial issues, however does currently support the new code in Sonarqube 8.2, as well setting the URL in Gitlab

mclayton7 · 2020-04-19T23:02:24Z

@mc1arke this is great. Are you up for adding #145 to this?

thorus90 · 2020-05-07T06:43:13Z

Any chance that will be integrated soon?

mc1arke · 2020-05-07T07:21:46Z

Given this doesn't seem to identify new versus old issues correctly, I'm not keen on merging it, but also haven't had time to investigate why it's not working properly yet.

k2589 · 2020-05-07T16:43:35Z

I builded jar from this branch, but on launch I get this error:

Error: Unable to initialize main class org.sonar.application.App

Caused by: java.lang.NoClassDefFoundError: org/sonar/application/config/AppSettingsLoader

thib3113 · 2020-05-12T10:26:28Z

Hello, I'm trying to build your branch, run it on sonarqube 8.3.
sonarqube crash with :

java.lang.IllegalStateException: Current edition does not support branch feature
	at com.google.common.base.Preconditions.checkState(Preconditions.java:508)
	at org.sonar.server.ce.queue.BranchSupport.createComponentKey(BranchSupport.java:63)

But the plugin is correctly present in plugin section (in sonarqube), and in the plugin folder (and lib/commons) .

and I can't select a branch on the homepage .

I'll retry with changing (in build.gradle) :

def sonarqubeVersion = '8.3.1.34397'

migueltg · 2020-05-13T08:46:18Z

Hello, I'm trying to build your branch, run it on sonarqube 8.3.
sonarqube crash with :
java.lang.IllegalStateException: Current edition does not support branch feature
	at com.google.common.base.Preconditions.checkState(Preconditions.java:508)
	at org.sonar.server.ce.queue.BranchSupport.createComponentKey(BranchSupport.java:63)
But the plugin is correctly present in plugin section (in sonarqube), and in the plugin folder (and lib/commons) .

and I can't select a branch on the homepage .

I'll retry with changing (in build.gradle) :
def sonarqubeVersion = '8.3.1.34397'

Not working for me, i get this error doing the build


com.github.mc1arke.sonarqube.plugin.ce.pullrequest.gitlab.GitlabServerPullRequestDecoratorTest > decorateQualityGateStatus FAILED
    com.github.tomakehurst.wiremock.common.FatalStartupException
        Caused by: java.lang.RuntimeException
            Caused by: java.net.BindException

Any suggestion?

EDIT: Test Failed, but lib is working 😃

thib3113 · 2020-05-13T09:28:13Z

@migueltg it is correctly working for you ? on 8.3 ?

migueltg · 2020-05-13T10:44:38Z

@migueltg it is correctly working for you ? on 8.3 ?

I don´t test all but branches are working with 8.3.1.34397

tisoft · 2020-05-13T11:33:20Z

I also tested against 8.3.1.34397 and it seems to work the same way as with 8.2.

thib3113 · 2020-05-13T12:07:42Z

hum ... I think I miss something ...
I'm coming directly from 8.0-beta ... And, the branch selector disapear with the new interface

but correctly detected on marketplace part ...

and when I run the sonar scanner (scan failed, and sonarqube log:) :

2020.05.13 12:04:50 ERROR web[AXINW+tdEVL7+LyrAADA][o.s.s.w.WebServiceEngine] Fail to process request http://sonarqube.srv/api/ce/submit?projectKey=myProject&projectName=myProject%20Api&characteristic=branch%3Drenovate%2Fnode-12.x&characteristic=branchType%3DBRANCH
java.lang.IllegalStateException: Current edition does not support branch feature
	at com.google.common.base.Preconditions.checkState(Preconditions.java:508)
	at org.sonar.server.ce.queue.BranchSupport.createComponentKey(BranchSupport.java:63)
	at org.sonar.server.ce.queue.ReportSubmitter.submit(ReportSubmitter.java:83)

Seems to be linked to /lib/commons ... but in theory, I have change it .... I'll retry...

Ok I found ...
On 8.0-beta, /lib/commons was /opt/sq/lib/common, now it's /opt/sonarqube/lib/common ... works really better now ... thank you

Baiskey · 2020-05-19T06:17:30Z

It seems that some merge conflicts appeared. What's more, can I ask someone to make a review for this PR?

.../github/mc1arke/sonarqube/plugin/ce/pullrequest/gitlab/GitlabServerPullRequestDecorator.java

hydezhao · 2020-06-01T14:09:29Z

I am testing sq-8_2-support on a sonarqube 8.2, everything works pretty well except i cannot find where to configure the patterns of long-term branch.

Should it suppose to be under General ?

mc1arke · 2020-06-01T14:15:14Z

@hydezhao there's no longer the concept of short or long term branch. All branches are baselined against the main branch (i.e. master). You can manage how long branches are retained for though: https://docs.sonarqube.org/latest/branches/overview/#header-3

sonarcloud · 2020-06-07T14:26:33Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

100.0% Coverage
0.0% Duplication

teuno · 2020-07-06T11:09:50Z

Is only the review needed, or something else too?

sergiocoronel · 2020-07-07T11:47:16Z

Do you have an estimation on when it will be reviewed?

ksl67 · 2020-07-12T09:49:00Z

Will it include support for Bitbucket Cloud Code Insights?

Sonarqube 8.2 introduced a new `ProjectDto` with associated changes in `ProjectAlmSettingsDao` to require this new class in various methods, as well as changes in `ComponentFinder` to allow retrieval of instances of a project. This change makes use of these new classes and methods to allow the Web Services for setting up ALM bindings to operate. As this class and the associated methods did not exist in previous versions of Sonarqube, this change breaks backwards compatibility, so means the plugin will now only support Sonarqube 8.2. Sonarqube 8.2 also provides the ability to set the optional URL parameter on a Gitlab project so that scans run outside of Gitlab CI operate properly, so the additional parameter is now included in the appropriate WebServices and the Gitlab decorator.

sonarcloud · 2020-07-17T13:53:58Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

100.0% Coverage
0.0% Duplication

mc1arke force-pushed the sq-8_2-support branch from 3de3916 to fd8ece2 Compare April 20, 2020 06:15

This was referenced Apr 20, 2020

fix(binding_action): sonarqube api break change for select by project #153

Closed

Not Able to integrate ALM on Azure Devops Server #152

Closed

mc1arke closed this Apr 26, 2020

mc1arke reopened this Apr 26, 2020

mc1arke force-pushed the sq-8_2-support branch 2 times, most recently from e0df748 to e7219c4 Compare May 17, 2020 17:58

dhpagani reviewed May 28, 2020

View reviewed changes

.../github/mc1arke/sonarqube/plugin/ce/pullrequest/gitlab/GitlabServerPullRequestDecorator.java Outdated Show resolved Hide resolved

mc1arke force-pushed the sq-8_2-support branch 2 times, most recently from ca7c16f to fb5af34 Compare June 7, 2020 14:24

mc1arke force-pushed the sq-8_2-support branch from fb5af34 to 656ed1e Compare July 17, 2020 13:50

mc1arke merged commit f624269 into master Jul 17, 2020

mc1arke deleted the sq-8_2-support branch July 17, 2020 21:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Sonarqube 8.2.0 #156

Add support for Sonarqube 8.2.0 #156

mc1arke commented Apr 19, 2020

mc1arke commented Apr 19, 2020

mclayton7 commented Apr 19, 2020

thorus90 commented May 7, 2020

mc1arke commented May 7, 2020

k2589 commented May 7, 2020

thib3113 commented May 12, 2020

migueltg commented May 13, 2020 •

edited

Loading

thib3113 commented May 13, 2020

migueltg commented May 13, 2020

tisoft commented May 13, 2020

thib3113 commented May 13, 2020 •

edited

Loading

Baiskey commented May 19, 2020

hydezhao commented Jun 1, 2020

mc1arke commented Jun 1, 2020

sonarcloud bot commented Jun 7, 2020

teuno commented Jul 6, 2020

sergiocoronel commented Jul 7, 2020

ksl67 commented Jul 12, 2020

sonarcloud bot commented Jul 17, 2020

Add support for Sonarqube 8.2.0 #156

Add support for Sonarqube 8.2.0 #156

Conversation

mc1arke commented Apr 19, 2020

mc1arke commented Apr 19, 2020

mclayton7 commented Apr 19, 2020

thorus90 commented May 7, 2020

mc1arke commented May 7, 2020

k2589 commented May 7, 2020

thib3113 commented May 12, 2020

migueltg commented May 13, 2020 • edited Loading

thib3113 commented May 13, 2020

migueltg commented May 13, 2020

tisoft commented May 13, 2020

thib3113 commented May 13, 2020 • edited Loading

Baiskey commented May 19, 2020

hydezhao commented Jun 1, 2020

mc1arke commented Jun 1, 2020

sonarcloud bot commented Jun 7, 2020

teuno commented Jul 6, 2020

sergiocoronel commented Jul 7, 2020

ksl67 commented Jul 12, 2020

sonarcloud bot commented Jul 17, 2020

migueltg commented May 13, 2020 •

edited

Loading

thib3113 commented May 13, 2020 •

edited

Loading