#154: Correctly report more than 50 issues to Github #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix for any pull request that had more than 50 issues had allowed an initial check run to be created, and then submitted the next batch of 50 issues to Github but failed to parse the response properly, so threw an error at that point, subsequently only submitting 100 issues to Github for each scan before causing the Compute Engine task to fail. The correct type is now being specified for the parse of Github's response, and unnecessary fields in the expected response object have been removed to allow the response to be parsed properly.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix for any pull request that had more than 50 issues had allowed an initial check run to be created, and then submitted the next batch of 50 issues to Github but failed to parse the response properly, so threw an error at that point, subsequently only submitting 100 issues to Github for each scan before causing the Compute Engine task to fail. The correct type is now being specified for the parse of Github's response, and unnecessary fields in the expected response object have been removed to allow the response to be parsed properly.