Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sonarcloud scan for PR #183

Closed
wants to merge 2 commits into from
Closed

Fix Sonarcloud scan for PR #183

wants to merge 2 commits into from

Conversation

crazy-max
Copy link
Contributor

@crazy-max crazy-max commented Jun 7, 2020 •
edited
Loading

@mc1arke
Copy link
Owner

mc1arke commented Jun 7, 2020

Is it worth making the Sonarqube task dependent on the presence of the SONAR_TOKEN secret? Until Github work out an easy way of handling secrets across forks, anyone who submits a PR, or even commits to their own fork without having setup the local secrets is going to get a check failure which isn't a great experience.

@mc1arke
Copy link
Owner

mc1arke commented Jun 7, 2020

Superseded by #184. Thanks for taking the time to look at this anyway,

@mc1arke mc1arke closed this Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crazy-max @mc1arke