#243: Handle no messages in error response from Bitbucket

src/main/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/bitbucket/client/model/server/ErrorResponse.java

@@ -22,6 +22,7 @@
 
 import java.io.Serializable;
 import java.util.Collections;
+import java.util.Optional;
 import java.util.Set;
 
 public class ErrorResponse implements Serializable {
@@ -32,7 +33,7 @@ public ErrorResponse(@JsonProperty("errors") Set<Error> errors) {
     }
 
     public Set<Error> getErrors() {
-        return Collections.unmodifiableSet(errors);
+        return Optional.ofNullable(errors).map(Collections::unmodifiableSet).orElse(null);
     }
 
     public static class Error implements Serializable {

src/test/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/bitbucket/client/BitbucketExceptionTest.java

@@ -0,0 +1,33 @@
+/*
+ * Copyright (C) 2020 Michael Clarke
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ *
+ */
+package com.github.mc1arke.sonarqube.plugin.ce.pullrequest.bitbucket.client;
+
+import com.github.mc1arke.sonarqube.plugin.ce.pullrequest.bitbucket.client.model.server.ErrorResponse;
+import org.junit.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class BitbucketExceptionTest {
+
+    @Test
+    public void verifyMessageReturnedWhenErrorResponseContainsNoErrors() {
+        BitbucketException testCase = new BitbucketException(401, new ErrorResponse(null));
+        assertThat(testCase.getMessage()).isEqualTo("Bitbucket responded with an error status (401)");
+    }
+}