Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarQube 10.5 compatibility #904

Merged
merged 1 commit into from
Aug 11, 2024
Merged

SonarQube 10.5 compatibility #904

merged 1 commit into from
Aug 11, 2024

Conversation

dkeitzel
Copy link
Contributor

As far as I know this should be enough to produce a binary compatible plugin for SonarQube 10.5. See also #900 (comment).

@mc1arke
Copy link
Owner

mc1arke commented Apr 26, 2024

This change isn't actually required: we only need the Sonarqube build dependency to allow us to compile the plugin. Given 10.5 hasn't changed any of the APIs we use then there's nothing that we need to change; I just need to push docker images and update the README

@mc1arke mc1arke closed this Apr 26, 2024
@dkeitzel
Copy link
Contributor Author

Are you sure? I'm by no means an expert in Java binary compatibility 😅. But at least the return type of ProjectAlmSettingDao#insertOrUpdate changed.

@mc1arke
Copy link
Owner

mc1arke commented May 6, 2024

Are you sure? I'm by no means an expert in Java binary compatibility 😅. But at least the return type of ProjectAlmSettingDao#insertOrUpdate changed.

Sorry, I'd missed that change, and yes it will cause problems for anyone creating a new ALM setting. This means we'll need to create a release purely for 10.5 😞

@mc1arke mc1arke reopened this May 6, 2024
@tina-junold
Copy link

Any news on this?

@zisuu
Copy link

zisuu commented May 24, 2024

would be nice to get this solved soon. We're currently having people that can't change some settings in their Projects due to this. Thanks a lot for your efforts 👍

@gjabouley-invn
Copy link

Hello
as usual for people in a hurry, SNAPSHOT version built from this PR can be downloaded using GitHub checks artefacts: https://github.com/mc1arke/sonarqube-community-branch-plugin/actions/runs/8969366962/artifacts/1476415257

@gjabouley-invn
Copy link

Are you sure? I'm by no means an expert in Java binary compatibility 😅. But at least the return type of ProjectAlmSettingDao#insertOrUpdate changed.

Sorry, I'd missed that change, and yes it will cause problems for anyone creating a new ALM setting. This means we'll need to create a release purely for 10.5 😞

You will probably need to build a new version for each new version of SQ, why not aligning the plugin version number with SQ version ? ;)

@benoit-waldmann
Copy link

Any news on this? @mc1arke

@FelixReuter
Copy link

Since this PR still is open: By now SQ has released at least one newer build of 10.5: 10.5.1.90531

@gjabouley-invn
Copy link

There shall not be any issue with new SQ 10.5 release.
This plugin depends on API, and those are never modified for bugfixes releases. So at first sight no need update the SQ dependency version.

@apetrelli
Copy link

I hope @mc1arke is ok... Probably he just lost the enthusiasm to maintain this project.

@mc1arke
Copy link
Owner

mc1arke commented Jun 14, 2024

I hope @mc1arke is ok... Probably he just lost the enthusiasm to maintain this project.

I'm ok, and haven't lost enthusiasm, just capacity to be able to perform testing of releases for now

@zisuu
Copy link

zisuu commented Jun 20, 2024

Hello, fyi we decided to try the snapshot version of 1.19.1. As far as we can say from user experience, it seems to work without any new issues, and we are again capable of editing the sonar project configs 👍 thanks a lot.

@a-mnich
Copy link

a-mnich commented Jun 20, 2024

Hi, we are also using the snapshot productively for about a month now. No issues so far.

@gjabouley-invn
Copy link

gjabouley-invn commented Jun 20, 2024

@mc1arke seems that this PR contains the only small change necessary to make the plugin compatible with 10.5, feedbacks are positive, can you please merge and go for a 1.10 ?

@adrianmusante
Copy link

I built the Docker image adrianmusante/sonarqube:10.5 which already has the plugin pre-configured, hopefully it will be of use to someone.

@florianmutter
Copy link

Any updates here?

@ummarbhutta
Copy link

When this PR will be merged?

@this-is-tobi this-is-tobi mentioned this pull request Jul 28, 2024
@mc1arke mc1arke merged commit c5a5a73 into mc1arke:master Aug 11, 2024
7 checks passed
@this-is-tobi
Copy link

Thanks for the merge @mc1arke, is there a release planned ?

@Asmabagwan1
Copy link

@mc1arke We have recently upgrade our SonarQube from 7.8 to 10.5 successfully.
We are facing issue with branch analysis. We have installed community branch plugin for this with version 1.22.0, but this plugin after installation is not reflecting on web UI. I have done all the configurations mentioned here https://github.com/mc1arke/sonarqube-community-branch-plugin in manual installation.

Please help us resolve this issue

@chriscarpenter12
Copy link

@Asmabagwan1 1.22.0 is only compatible with sonarqube 10.6. It's on the readme

https://github.com/mc1arke/sonarqube-community-branch-plugin?tab=readme-ov-file#compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.