Fix for node 6.x. Be explicit about crypto update input encoding latin1

mcastany · Jan 20, 2017 · e11daba · e11daba
1 parent 3df3060
commit e11daba
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -2,4 +2,6 @@ language: node_js
 before_install: npm i -g [email protected]
 node_js:
   - 0.8
-  - 0.10
+  - 0.10
+  - 4
+  - 6
diff --git a/lib/passport-wsfed-saml2/saml.js b/lib/passport-wsfed-saml2/saml.js
@@ -59,7 +59,7 @@ SAML.prototype.validateSignature = function (xml, options, callback) {
           var base64cer = embeddedSignature[0].firstChild.toString();
           var shasum = crypto.createHash('sha1');
           var der = new Buffer(base64cer, 'base64').toString('binary');
-          shasum.update(der);
+          shasum.update(der, 'latin1');
           self.calculatedThumbprint = shasum.digest('hex');
 
           // using embedded cert, so options.cert is not used anymore

diff --git a/lib/passport-wsfed-saml2/samlp.js b/lib/passport-wsfed-saml2/samlp.js
@@ -68,7 +68,7 @@ var removeHeaders = function  (cert) {
 
 var sign = function (content, key, algorithm) {
   var signer = crypto.createSign(algorithm.toUpperCase());
-  signer.update(content);
+  signer.update(content, 'latin1');
   return signer.sign(key, 'base64');
 };