Merge pull request gimli-rs#247 from bjorn3/elf_write_weak_fix

write/elf: Check symbol.weak before symbol.is_undefined()
mcbegamerxx954 · Aug 18, 2020 · 7f45093 · 7f45093
2 parents caa91db + 44c4789
commit 7f45093
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/write/elf.rs b/src/write/elf.rs
@@ -468,12 +468,12 @@ impl Object {
                         }
                     }
                 };
-                let st_bind = if symbol.is_undefined() {
+                let st_bind = if symbol.weak {
+                    elf::STB_WEAK
+                } else if symbol.is_undefined() {
                     elf::STB_GLOBAL
                 } else if symbol.is_local() {
                     elf::STB_LOCAL
-                } else if symbol.weak {
-                    elf::STB_WEAK
                 } else {
                     elf::STB_GLOBAL
                 };