Skip to content

Commit

Permalink
power: supply: Use IRQF_ONESHOT
Browse files Browse the repository at this point in the history
Fixes coccicheck error:

drivers/power/supply/pm2301_charger.c:1089:7-27: ERROR:
drivers/power/supply/lp8788-charger.c:502:8-28: ERROR:
drivers/power/supply/tps65217_charger.c:239:8-33: ERROR:
drivers/power/supply/tps65090-charger.c:303:8-33: ERROR:

Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Signed-off-by: dongjian <[email protected]>
Signed-off-by: Sebastian Reichel <[email protected]>
  • Loading branch information
dongjian authored and sre committed Mar 22, 2021
1 parent 4eed7f5 commit 2469b83
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/power/supply/lp8788-charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ static int lp8788_set_irqs(struct platform_device *pdev,

ret = request_threaded_irq(virq, NULL,
lp8788_charger_irq_thread,
0, name, pchg);
IRQF_ONESHOT, name, pchg);
if (ret)
break;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/pm2301_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -1089,7 +1089,7 @@ static int pm2xxx_wall_charger_probe(struct i2c_client *i2c_client,
ret = request_threaded_irq(gpio_to_irq(pm2->pdata->gpio_irq_number),
NULL,
pm2xxx_charger_irq[0].isr,
pm2->pdata->irq_type,
pm2->pdata->irq_type | IRQF_ONESHOT,
pm2xxx_charger_irq[0].name, pm2);

if (ret != 0) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/tps65090-charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ static int tps65090_charger_probe(struct platform_device *pdev)

if (irq != -ENXIO) {
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
tps65090_charger_isr, 0, "tps65090-charger", cdata);
tps65090_charger_isr, IRQF_ONESHOT, "tps65090-charger", cdata);
if (ret) {
dev_err(cdata->dev,
"Unable to register irq %d err %d\n", irq,
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/tps65217_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ static int tps65217_charger_probe(struct platform_device *pdev)
for (i = 0; i < NUM_CHARGER_IRQS; i++) {
ret = devm_request_threaded_irq(&pdev->dev, irq[i], NULL,
tps65217_charger_irq,
0, "tps65217-charger",
IRQF_ONESHOT, "tps65217-charger",
charger);
if (ret) {
dev_err(charger->dev,
Expand Down

0 comments on commit 2469b83

Please sign in to comment.