Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic support for targets related to wasm32. #53

Merged
merged 15 commits into from
Nov 17, 2023
Merged

Add basic support for targets related to wasm32. #53

merged 15 commits into from
Nov 17, 2023

Conversation

TheVeryDarkness
Copy link
Contributor

Map rust target wasm32-unknown-emscripten and wasm32-unknown-unknown to vcpkg triplet wasm32-emscripten.

@TheVeryDarkness
Basic support for targets related to wasm32
ecc87a4 
Map rust target wasm32-unknown-emscripten and wasm32-unknown-unknown to vcpkg triplet wasm32-emscripten.
@TheVeryDarkness
Format the codes.
e084b65
TheVeryDarkness added a commit to TheVeryDarkness/z3.rs that referenced this pull request Oct 13, 2023
@TheVeryDarkness
Add basic support for vcpkg.
163f80c 
Use vcpkg-rs to manage z3 instead. A non-default feature vcpkg is added.

However, vcpkg-rs does not support wasm32 target currently. I created a pull request there at mcgoo/vcpkg-rs#53
@TheVeryDarkness TheVeryDarkness mentioned this pull request Oct 13, 2023
Merged
@pkgw
Copy link
Collaborator

pkgw commented Oct 13, 2023

Thanks for submitting! It would be great to also add some test coverage and brief documentation to go along with this support, if you're able.

@TheVeryDarkness
Copy link
Contributor Author

Okay, but I'm afraid that I need some time for it. I may be busy for several days as I'm attending a game.

@TheVeryDarkness
Copy link
Contributor Author

@pkgw I've added a test for wasm32-unknown-unknown target and added a little documentation. But the workflows just failed the same as it did on Linux and macOS. You can see it in actions.

@TheVeryDarkness
Copy link
Contributor Author

Sorry the commit about documentation hasn't be pushed to github yet. Bad network.

@TheVeryDarkness
Remove explicit linkage include in tests.
8346ada 
I guess brotlicommon-static has already been a static library so we don't need that.

Test this later on Windows.
@TheVeryDarkness
Merge branch 'master' into combined
603ff6c 
Combine two PRs together to test them.
@TheVeryDarkness
Copy link
Contributor Author

Sorry the commit about documentation hasn't be pushed to github yet. Bad network.

I mean 4edd92f.

@TheVeryDarkness
Copy link
Contributor Author

@pkgw Any more suggestions?

@pkgw
test/harfbuzz/build.rs: remove outdated comment
f9e7eaf 
The comment is no longer operative now that the println is gone.
@pkgw
Copy link
Collaborator

pkgw commented Nov 14, 2023

I'm very sorry, I've fallen far behind on my GitHub activity lately. I've simply punted on most things that were in my queue and am trying to catch back up. This now looks good to me, especially since it is such a non-invasive change. @waych please shout in the next few days if you have any comments here, otherwise I'll go ahead and merge.

@pkgw pkgw merged commit 2d6a687 into mcgoo:master Nov 17, 2023
10 checks passed
@TheVeryDarkness TheVeryDarkness mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheVeryDarkness @pkgw