Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #120, improving performance when passing a
struct
to a method using thein
keyword.MS Docs
Blogpost with more insight
Stack overflow discussion
TL;DR
Using
in
for a parameter lets us pass by reference, but then prevents us from assigning a value to it. However the performance can actually become worse, because it creates a "defensive copy" of thestruct
, copying the whole thing. A way around this is to use read-only for astruct
. When you pass it into anin
parameter, the compiler sees that it's read-only and won't create the defensive copy, thereby making it the better alternative for performance.