Rewrite ISourceGenerator into IIncrementalGenerator #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcintyre321 The new source generator needs the .NET 6 SDK/Compiler in order to build successfully. I obviously don't have access to your build agent/pipeline. Are you able to upgrade the build to use the .NET 6 SDK? |
|
@mcintyre321 do you still maintain this package? |
|
Sorry, I haven't had a lot of time to review the PRs lately
I do wonder if the source generator should be spun into a different repo as
I wasn't the creator of it, and have less context when reviewing changes,
so it takes longer.
…On Mon, 12 Jun 2023, 11:19 Tom Longhurst, ***@***.***> wrote:
@mcintyre321 <https://github.com/mcintyre321> do you still maintain this
package?
—
Reply to this email directly, view it on GitHub
<#148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACDJ6UM6QTFYKDTDX4ZCGLXK3ULLANCNFSM6AAAAAAYFRSYJA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
If we can get it building the tests should demonstrate that it's behaving much the same |
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISourceGenerator is the old (and slower) way of generating source files and can come with severe performance issues while writing code in your IDE.
IIncrementalGenerator is the newer way to generate source files, with better performance due to how it works under the hood, detecting changes etc.
I've tried to keep the class generation code as much the same as possible.